necouchman commented on PR #911: URL: https://github.com/apache/guacamole-client/pull/911#issuecomment-1741961729
Okay, I think I've got the checks working. I'm currently hitting three issues: * Build is impacted by the odd Bouncycastle version update. Once that's fixed the build will work properly. * If I try to use Tomcat with its default IPv4 + IPv6 dual-stack enabled, the `request.getRemoteAddr()` call periodically flips between the actual IPv4 client IP and an IPv6 loopback IP (0:0:0:0:0:0:0:0:1 - or some number of 0s). I was able to pretty well remove this by adding `-Djava.net.preferIPv4Stack=true` to `CATALINA_OPTS` in the Tomcat startup, but ideally this would be able to reliably handle both IPv4 and IPv6. If anyone has any hints for that, I'm open. * I had to make some unusual changes to the IPAddress detection code because I couldn't loop through a `List` of `IPAddress` types - I'd get an error about how `IPv4Address` couldn't be cast to `IPAddress`. What's even more weird is that I converted everything to `IPAddressString` data types, and I can't even do a `for (IPAddressString ipAddr : ipAddrList)` - I get the same error about being unable to cast it. Again, if anyone has hints, I'm open to them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
