jmuehlner commented on code in PR #911:
URL: https://github.com/apache/guacamole-client/pull/911#discussion_r1386932908
##########
extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/UserVerificationService.java:
##########
@@ -71,10 +74,60 @@ public void verifyAuthenticatedUser(AuthenticatedUser
authenticatedUser)
// Pull the original HTTP request used to authenticate
Credentials credentials = authenticatedUser.getCredentials();
HttpServletRequest request = credentials.getRequest();
+ IPAddress clientAddr = new
IPAddressString(request.getRemoteAddr()).getAddress();
// Ignore anonymous users
if
(authenticatedUser.getIdentifier().equals(AuthenticatedUser.ANONYMOUS_IDENTIFIER))
return;
+
+ // We enforce by default
+ boolean enforceHost = true;
Review Comment:
I was mostly talking about [this code
block](https://github.com/apache/guacamole-client/pull/911/files#diff-5ce38f439ffddba700c3d8ca58d67bd7d1a2e377f6ac852783b1109df0107d8cR84-R130)
from lines 84 to 130, and the similar code block in the TOTP
`UserVerificationService.java` (sorry, that was unclear...)
If there's other similar code that you think should be shared, I'm
definitely open to that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
