necouchman commented on code in PR #911:
URL: https://github.com/apache/guacamole-client/pull/911#discussion_r1398293051
##########
extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/UserVerificationService.java:
##########
@@ -71,10 +74,60 @@ public void verifyAuthenticatedUser(AuthenticatedUser
authenticatedUser)
// Pull the original HTTP request used to authenticate
Credentials credentials = authenticatedUser.getCredentials();
HttpServletRequest request = credentials.getRequest();
+ IPAddress clientAddr = new
IPAddressString(request.getRemoteAddr()).getAddress();
// Ignore anonymous users
if
(authenticatedUser.getIdentifier().equals(AuthenticatedUser.ANONYMOUS_IDENTIFIER))
return;
+
+ // We enforce by default
+ boolean enforceHost = true;
Review Comment:
Okay - I took some of the common code and moved it into a utility class in
`guacamole-ext`. I was trying to balance collecting common code against putting
too much extension-specific code into the `guacamole-ext` code, but if you
think there's more that should get consolidated into it, I'm happy to take
another go at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
