jmuehlner commented on code in PR #497:
URL: https://github.com/apache/guacamole-server/pull/497#discussion_r1523706085
##########
src/protocols/rdp/rdp.c:
##########
@@ -115,7 +115,6 @@ BOOL rdp_freerdp_pre_connect(freerdp* instance) {
/* Downgrade the lock to allow for concurrent read access */
guac_rwlock_release_lock(&(rdp_client->lock));
- guac_rwlock_acquire_read_lock(&(rdp_client->lock));
Review Comment:
Isn't this going to just result in no lock being held at all? It sure looks
like the read lock is still needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
