jmuehlner commented on code in PR #497:
URL: https://github.com/apache/guacamole-server/pull/497#discussion_r1524017700
##########
src/protocols/rdp/rdp.c:
##########
@@ -115,7 +115,6 @@ BOOL rdp_freerdp_pre_connect(freerdp* instance) {
/* Downgrade the lock to allow for concurrent read access */
guac_rwlock_release_lock(&(rdp_client->lock));
- guac_rwlock_acquire_read_lock(&(rdp_client->lock));
Review Comment:
Ah, right you are. Ignore me.
##########
src/protocols/rdp/rdp.c:
##########
@@ -537,6 +536,7 @@ static int guac_rdp_handle_connection(guac_client* client) {
}
/* Upgrade to write lock again for further exclusive operations */
+ guac_rwlock_release_lock(&(rdp_client->lock));
Review Comment:
Nevermind, I am confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
