jmuehlner commented on PR #497: URL: https://github.com/apache/guacamole-server/pull/497#issuecomment-1995229980
I think at least some of what coverity's reporting here are actually false positives. It doesn't seem to understand the `guac_rwlock` functionality very well, and how it will lock/unlock based on the value of the thread-local. Additionally, I think it might be confused about how the various FreeRDP callbacks work (i.e. `rdp_freerdp_pre_connect`). It's understandably upset that the function acquires a lock and never releases it, because it doesn't know that it's invoked from within a section of code that already holds that lock... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
