necouchman commented on code in PR #530:
URL: https://github.com/apache/guacamole-server/pull/530#discussion_r2384254145
##########
src/protocols/kubernetes/settings.c:
##########
@@ -212,6 +213,16 @@ enum KUBERNETES_ARGS_IDX {
*/
IDX_RECORDING_INCLUDE_KEYS,
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
Review Comment:
Is it only "paste" data, or would it also include copy events?
##########
src/protocols/kubernetes/settings.h:
##########
@@ -240,6 +240,16 @@ typedef struct guac_kubernetes_settings {
*/
bool recording_include_keys;
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
+ * Key events are NOT included by default within the recording,
Review Comment:
`clipboard paste data` or just `clipboard data`?
`key events" -> `Clipboard events`?
##########
src/protocols/rdp/settings.c:
##########
@@ -560,6 +561,16 @@ enum RDP_ARGS_IDX {
*/
IDX_RECORDING_INCLUDE_KEYS,
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
+ * Key events are NOT included by default within the recording,
Review Comment:
And, again, here - with `paste data` and `Key events`...
##########
src/protocols/vnc/settings.h:
##########
@@ -285,6 +285,16 @@ typedef struct guac_vnc_settings {
*/
bool recording_include_keys;
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
+ * Key events are NOT included by default within the recording,
Review Comment:
And here.
##########
src/protocols/telnet/settings.h:
##########
@@ -245,6 +245,16 @@ typedef struct guac_telnet_settings {
*/
bool recording_include_keys;
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
+ * Key events are NOT included by default within the recording,
Review Comment:
And here.
##########
src/protocols/kubernetes/settings.c:
##########
@@ -212,6 +213,16 @@ enum KUBERNETES_ARGS_IDX {
*/
IDX_RECORDING_INCLUDE_KEYS,
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
+ * Key events are NOT included by default within the recording,
Review Comment:
Maybe some copy-pasta, here - `Key events` -> `Clipboard events`?
##########
src/protocols/telnet/settings.c:
##########
@@ -195,6 +196,16 @@ enum TELNET_ARGS_IDX {
*/
IDX_RECORDING_INCLUDE_KEYS,
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
+ * Key events are NOT included by default within the recording,
Review Comment:
And another one.
##########
src/protocols/ssh/settings.c:
##########
@@ -243,6 +244,16 @@ enum SSH_ARGS_IDX {
*/
IDX_RECORDING_INCLUDE_KEYS,
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
+ * Key events are NOT included by default within the recording,
Review Comment:
And here.
##########
src/protocols/ssh/settings.h:
##########
@@ -257,6 +257,16 @@ typedef struct guac_ssh_settings {
*/
bool recording_include_keys;
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
+ * Key events are NOT included by default within the recording,
Review Comment:
Another instance.
##########
src/protocols/rdp/settings.h:
##########
@@ -559,6 +559,16 @@ typedef struct guac_rdp_settings {
*/
int recording_include_keys;
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
+ * Key events are NOT included by default within the recording,
Review Comment:
And here.
##########
src/protocols/vnc/settings.c:
##########
@@ -329,6 +330,16 @@ enum VNC_ARGS_IDX {
*/
IDX_RECORDING_INCLUDE_KEYS,
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
+ * Key events are NOT included by default within the recording,
Review Comment:
Here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
