necouchman commented on code in PR #530:
URL: https://github.com/apache/guacamole-server/pull/530#discussion_r2388224112
##########
src/protocols/kubernetes/settings.c:
##########
@@ -212,6 +213,16 @@ enum KUBERNETES_ARGS_IDX {
*/
IDX_RECORDING_INCLUDE_KEYS,
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
Review Comment:
In that case, I wonder if it would be worth changing the overall parameter
name to better reflect what we're capturing, in case we do want to add
something different in the future. Your point about the size of the recording
capturing certain clipboard data is well-taken, and I'm not sure it makes sense
to add that (now), I just think we want to be very clear about what data we're
capturing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
