lukasraska commented on code in PR #530:
URL: https://github.com/apache/guacamole-server/pull/530#discussion_r2388191792
##########
src/protocols/kubernetes/settings.c:
##########
@@ -212,6 +213,16 @@ enum KUBERNETES_ARGS_IDX {
*/
IDX_RECORDING_INCLUDE_KEYS,
+ /**
+ * Whether clipboard paste data should be included in the session
recording.
Review Comment:
As of now, it only reports paste data -> those within the user-originating
clipboard blobs. I aimed this to give better insight into what is the actual
data transfered in, since currently if somebody pastes some command via
clipboard, it's not really visible in the recordings (merely the UI changes are
rendered, whatever happens based on that).
If also server-originating clipboard changes should be logged, from brief
check it should probably be easy to hook it up to `__send_user_clipboard` (or
probably the respective method that calls this for each connected user), but
that recording could get quite big in such cases (so if this would be desired,
I would probably aim for two separate args, like with the disable-copy/paste
options, so users can choose which one to log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
