On Tue, Aug 9, 2011 at 1:52 PM, Todd Lipcon <[email protected]> wrote: > Grumpy request #1 > ------------------------------
... > I'd like to propose the following guidelines for "followup commits > under the same JIRA": > 1) A followup commit is fine so long as it follows within 1 day of the > original commit. > 1a) The followup commit should include in the commit message a > description of what differs, eg a commit message format like: > "Amend HBASE-nnnn. Followup to previous commit which forgot to include > Foo.java" would be great. Or if it fixes some small bug in the > previous commit, "Amend HBASE-nnnn. Fix bug JD pointed out in > http://permalink-to-the-jira-comment";. > 2) A followup commit may never be done "across versions" - ie if a > JIRA has already been committed to any code base that's been released, > it can't be amended after that, even if the fix is trivial. > 3) Backport commits are of course OK so long as the patch is > essentially the same (eg if something's committed to 0.92.0, it can be > backported to 0.90.n if it's basically the same code) > > Does this seem reasonable? > Yes. > Grumpy request #2 > ----------------------------- > Recently we've had a lot of great significant contributions. A lot of > the time they've been committed very quickly -- ie from patch to > commit in a few hours. This is great for encouraging contributors, but > I'm worried we may lose some stability or may introduce features that > are questionable. For any patches that are complicated or introduce > new APIs, can we try to leave them open for at least a day or two > before commit? > > No problem. Lets get the above as the 'grumpy' tenets into our contrib doc on wiki or here in the book (if others agree): http://hbase.apache.org/book.html#getting.involved Good on you Todd. St.Ack
