garydgregory commented on code in PR #508:
URL:
https://github.com/apache/httpcomponents-core/pull/508#discussion_r1860245823
##########
httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/HttpRequestExecutor.java:
##########
@@ -212,7 +213,11 @@ public ClassicHttpResponse execute(
return response;
} catch (final HttpException | IOException | RuntimeException ex) {
- Closer.closeQuietly(conn);
+ if (http1Config.getUseRstOnTimeout()) {
Review Comment:
Is there a use case for keeping the old behavior?
##########
httpcore5/src/main/java/org/apache/hc/core5/http/config/Http1Config.java:
##########
@@ -222,6 +235,14 @@ public Builder setInitialWindowSize(final int
initialWindowSize) {
return this;
}
+ /**
+ * @since 5.4
Review Comment:
I think you need a real Javadoc description that explains what this toggle
does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
