ooeunz commented on code in PR #508:
URL:
https://github.com/apache/httpcomponents-core/pull/508#discussion_r1860475388
##########
httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/HttpRequestExecutor.java:
##########
@@ -212,7 +213,7 @@ public ClassicHttpResponse execute(
return response;
} catch (final HttpException | IOException | RuntimeException ex) {
- Closer.closeQuietly(conn);
Review Comment:
@ok2c Sure, but since SSLException is a subclass of IOException, I think it
should be worded like this.
```
} catch (final IOException | RuntimeException ex) {
Closer.close(conn, CloseMode.IMMEDIATE);
throw ex;
} catch (final HttpException ex) {
Closer.closeQuietly(conn);
throw ex;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
