ok2c commented on code in PR #566:
URL:
https://github.com/apache/httpcomponents-client/pull/566#discussion_r2019081568
##########
httpclient5/src/main/java/org/apache/hc/client5/http/psl/PublicSuffixMatcher.java:
##########
@@ -149,24 +148,30 @@ public String getDomainRoot(final String domain, final
DomainType expectedType)
}
final DomainType domainRule = findEntry(rules, key);
if (match(domainRule, expectedType)) {
- if (domainRule == DomainType.PRIVATE) {
Review Comment:
@massdosage Unfortunately this change introduced a regression in 5.4.x.
There is a reason for special treatment of `DomainType.PRIVATE`, we just did
not have a test case for it in our test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
