massdosage commented on code in PR #566:
URL:
https://github.com/apache/httpcomponents-client/pull/566#discussion_r2021369949
##########
httpclient5/src/main/java/org/apache/hc/client5/http/psl/PublicSuffixMatcher.java:
##########
@@ -149,24 +148,30 @@ public String getDomainRoot(final String domain, final
DomainType expectedType)
}
final DomainType domainRule = findEntry(rules, key);
if (match(domainRule, expectedType)) {
- if (domainRule == DomainType.PRIVATE) {
Review Comment:
Yes, I did say that this was a backwards-incompatible change as the previous
behaviour didn't match the formal algorithm behaviour. We only focused on that
aspect of it, if the `PublicSuffixListMatcher` is being used for other uses
cases then I can't comment on their correctness as we're using this on the
understanding that it implements the upstream standard. We're not using it for
SSL/TLS etc. which I think are out of scope of the standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
