LichKing-lee commented on code in PR #712:
URL:
https://github.com/apache/httpcomponents-client/pull/712#discussion_r2296849744
##########
httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionConfig.java:
##########
@@ -149,9 +149,19 @@ public Builder setSocketTimeout(final int soTimeout, final
TimeUnit timeUnit) {
}
/**
- * Determines the default socket timeout value for I/O operations.
+ * Determines the default socket timeout value for I/O operations on
+ * connections created by this configuration.
+ * A timeout value of zero is interpreted as an infinite timeout.
* <p>
- * Default: {@code null} (undefined)
+ * This value serves as the baseline timeout applied when a connection
is first
+ * created and managed by the connection pool.
+ * </p>
+ * <p>
+ * Please note: in classic (blocking) I/O execution, if a request-level
Review Comment:
Thanks for guidance.
I noticed through testing that in Apache HttpComponents, responseTimeout and
socketTimeout do not operate completely independently at execution time,
responseTimeout effectively overrides the socket’s read timeout. My intention
with this PR was to make that behavior clearer in the documentation.
Would the following revised wording be acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
