ok2c commented on code in PR #712:
URL:
https://github.com/apache/httpcomponents-client/pull/712#discussion_r2297700938
##########
httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionConfig.java:
##########
@@ -149,7 +149,15 @@ public Builder setSocketTimeout(final int soTimeout, final
TimeUnit timeUnit) {
}
/**
- * Determines the default socket timeout value for I/O operations.
+ * Determines the default socket timeout value for I/O operations on
+ * connections created by this configuration.
+ * A timeout value of zero is interpreted as an infinite timeout.
+ * <p>
+ * This value acts as a baseline configured by the I/O layer. It can be
Review Comment:
@LichKing-lee Actually this is not quite correct. The baseline is
established by the respective i/o layer (through `SocketConfig` for the classic
one or `IOReactorConfig` for the async one). Those settings apply to all newly
created connections / channels indiscriminately. `ConnectionConfig` is one
layer up and can apply selectively to specific hosts. This is reason
`ConnectionConfig` exists, so one could configure different connection settings
for specific hosts only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
