ok2c commented on code in PR #712:
URL:
https://github.com/apache/httpcomponents-client/pull/712#discussion_r2296731154
##########
httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionConfig.java:
##########
@@ -149,9 +149,19 @@ public Builder setSocketTimeout(final int soTimeout, final
TimeUnit timeUnit) {
}
/**
- * Determines the default socket timeout value for I/O operations.
+ * Determines the default socket timeout value for I/O operations on
+ * connections created by this configuration.
+ * A timeout value of zero is interpreted as an infinite timeout.
* <p>
- * Default: {@code null} (undefined)
+ * This value serves as the baseline timeout applied when a connection
is first
+ * created and managed by the connection pool.
+ * </p>
+ * <p>
+ * Please note: in classic (blocking) I/O execution, if a request-level
Review Comment:
@LichKing-lee I do not think this is the right place to mention any specific
i/o layers or anything that the protocol may or may not do. `RequestConfig` is
of no relevance here. What you can mention here instead is that the socket
timeout when specified at the connection layer overrides the default set by the
i/o layer and in its turn can be overridden by the protocol layer
##########
httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java:
##########
@@ -533,23 +533,25 @@ public Builder setConnectTimeout(final long
connectTimeout, final TimeUnit timeU
}
/**
- * Determines the timeout until arrival of a response from the opposite
- * endpoint.
- * <p>
+ * Determines the timeout until arrival of a response from the
opposite endpoint.
* A timeout value of zero is interpreted as an infinite timeout.
- * </p>
* <p>
- * Please note that response timeout may be unsupported by
- * HTTP transports with message multiplexing.
+ * Please note that response timeout may be unsupported by HTTP
transports with
+ * message multiplexing.
* </p>
* <p>
- * Please note that response timeout is not a deadline. Its absolute
value
- * can be exceeded, for example, in case of automatic request
re-execution.
- * Please make sure the automatic request re-execution policy has been
- * configured appropriately.
+ * Please note that response timeout is not a deadline. Its absolute
value can
+ * be exceeded, for example, in case of automatic request
re-execution. Please
+ * make sure the automatic request re-execution policy has been
configured
+ * appropriately.
* </p>
* <p>
- * Default: {@code null}
+ * In classic (blocking) I/O execution, if this value is set, it will
be applied
Review Comment:
@LichKing-lee Same here. You can mention that this parameter can override
the setting of the connection layer or the i/o layer but `ConnectionConfig` is
of no relevance here
##########
httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionConfig.java:
##########
@@ -149,9 +149,19 @@ public Builder setSocketTimeout(final int soTimeout, final
TimeUnit timeUnit) {
}
/**
- * Determines the default socket timeout value for I/O operations.
+ * Determines the default socket timeout value for I/O operations on
+ * connections created by this configuration.
+ * A timeout value of zero is interpreted as an infinite timeout.
* <p>
- * Default: {@code null} (undefined)
Review Comment:
@LichKing-lee I do not think this line should be removed.
##########
httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java:
##########
@@ -533,23 +533,25 @@ public Builder setConnectTimeout(final long
connectTimeout, final TimeUnit timeU
}
/**
- * Determines the timeout until arrival of a response from the opposite
- * endpoint.
- * <p>
+ * Determines the timeout until arrival of a response from the
opposite endpoint.
Review Comment:
@LichKing-lee Please avoid formatting changes in the same change-set with
the content changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
