ok2c commented on code in PR #726:
URL:
https://github.com/apache/httpcomponents-client/pull/726#discussion_r2361983826
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java:
##########
@@ -409,6 +415,7 @@ public ConnectionEndpoint get(
}
} finally {
lock.unlock();
Review Comment:
@arturobernalg The chances of anything going wrong in the remaining code is
super-slim. And if it did happen the queue would get drained by another call /
thread. But I think one `#drainDisposals` call should be enough here. Pick one
you prefer. I leave it up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
