arturobernalg commented on code in PR #726:
URL:
https://github.com/apache/httpcomponents-client/pull/726#discussion_r2360877446
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java:
##########
@@ -409,6 +415,7 @@ public ConnectionEndpoint get(
}
} finally {
lock.unlock();
Review Comment:
> @arturobernalg This is a lease lock., not a global pool lock. It is
perfectly OK to call `#drainDisposals` inside the method, for instance, at line
395 (prior to ` final ManagedHttpClientConnection conn =
poolEntry.getConnection();`)
@ok2c drainDisposals() now runs inside LeaseRequest#get right before
poolEntry.getConnection() (lease lock only), with the final safety drain
retained; tests updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
