ok2c commented on code in PR #726:
URL:
https://github.com/apache/httpcomponents-client/pull/726#discussion_r2359128711
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java:
##########
@@ -741,6 +753,9 @@ public void close(final CloseMode closeMode) {
final PoolEntry<HttpRoute, ManagedHttpClientConnection> poolEntry
= poolEntryRef.get();
if (poolEntry != null) {
poolEntry.discardConnection(closeMode);
+ if (disposer != null) {
Review Comment:
@arturobernalg I see no harm in delaying `#drainDisposals` execution until
the endpoint is passed to `#release`.
BUT, Please look at the `LeaseRequest#get`. Connections can be closed in the
course of that method. So, `#drainDisposals` should be called there. Please
investigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
