ok2c commented on code in PR #785:
URL:
https://github.com/apache/httpcomponents-client/pull/785#discussion_r2695982589
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java:
##########
@@ -444,6 +444,8 @@ public ConnectionEndpoint get(
conn.activate();
if (connectionConfig.getSocketTimeout() != null) {
conn.setSocketTimeout(connectionConfig.getSocketTimeout());
+ } else {
+
conn.setSocketTimeout(resolveSocketConfig(route).getSoTimeout());
Review Comment:
@rschmitt I cannot agree with that. I see no good reason to make behavior of
this class illogical and inconsistent because there is (or was) supposedly
another inconsistency somewhere else.
Again, if people want specific socket timeout they should explicitly set it
with `ConnectionConfig`. If they leave it null they are fine with it being
undefined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
