rschmitt commented on code in PR #785:
URL:
https://github.com/apache/httpcomponents-client/pull/785#discussion_r2696270846
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java:
##########
@@ -444,6 +444,8 @@ public ConnectionEndpoint get(
conn.activate();
if (connectionConfig.getSocketTimeout() != null) {
conn.setSocketTimeout(connectionConfig.getSocketTimeout());
+ } else {
+
conn.setSocketTimeout(resolveSocketConfig(route).getSoTimeout());
Review Comment:
OK, a minimal change to fix `responseTimeout` leaking across requests is to
change `DefaultManagedHttpClientConnection#setSocketTimeout` to simply not
update `this.socketTimeout`. In other words, the `socketTimeout` would be
captured at `bind` time and not updated after that, thus ensuring that
`activate()` always restores the connection default socket timeout and not a
request-scoped override value from `RequestConfig`. I have to slightly rework
UDS connection establishment, but it seems to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
