ok2c commented on code in PR #581:
URL:
https://github.com/apache/httpcomponents-core/pull/581#discussion_r2709431034
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/CancellableExecution.java:
##########
@@ -48,7 +49,11 @@ public void setDependency(final Cancellable cancellable) {
if (cancelled.get()) {
final Cancellable dependency = dependencyRef.getAndSet(null);
if (dependency != null) {
- dependency.cancel();
+ try {
Review Comment:
> It only reproduces when JUnit runs tests in parallel: mvn -pl
httpcore5-testing test fails , but
-Djunit.jupiter.execution.parallel.enabled=false makes it go away.
@arturobernalg Fair enough, but if you look at the exception stack trace,
what does it tell you? The best place to catch and ignore the exception is
obviously `H2Stream#abort`. Anyhow, this should fix the problem [1]. Please
re-base your change-set off the latest master and re-test.
[1] 6911f14c60654262059c5baf18730e6b65a811e5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
