rschmitt commented on code in PR #581:
URL:
https://github.com/apache/httpcomponents-core/pull/581#discussion_r2718744141
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/H2Stream.java:
##########
@@ -83,7 +88,7 @@ public State getState() {
@Override
public void setTimeout(final Timeout timeout) {
- // not supported
+ this.idleTimeout = timeout;
Review Comment:
This is so satisfying to see! I think this is the ideal outcome: zero API
changes (except for the new exception type), backfilling missing support for
existing APIs, improving consistency across protocols, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
