ok2c commented on code in PR #581:
URL: 
https://github.com/apache/httpcomponents-core/pull/581#discussion_r2721748470


##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/H2Stream.java:
##########
@@ -83,7 +88,7 @@ public State getState() {
 
     @Override
     public void setTimeout(final Timeout timeout) {
-        // not supported
+        this.idleTimeout = timeout;

Review Comment:
   @rschmitt Unfortunately this is not quite the case. I was unable to 
articulate to @arturobernalg exactly what API changes I wanted, so I ended up 
implementing them in a separate commit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to