ok2c commented on code in PR #581: URL: https://github.com/apache/httpcomponents-core/pull/581#discussion_r2721781427
########## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/H2StreamTimeoutException.java: ########## @@ -0,0 +1,62 @@ +/* + * ==================================================================== + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * ==================================================================== + * + * This software consists of voluntary contributions made by many + * individuals on behalf of the Apache Software Foundation. For more + * information on the Apache Software Foundation, please see + * <http://www.apache.org/>. + * + */ +package org.apache.hc.core5.http2; + +import java.io.InterruptedIOException; + +import org.apache.hc.core5.util.Timeout; + +/** + * {@link java.net.SocketTimeoutException} raised when an HTTP/2 stream exceeds its configured timeout. + * <p> + * This timeout is scoped to a single stream and is independent of the underlying connection socket timeout. + * </p> + * + * @since 5.5 + */ +public class H2StreamTimeoutException extends InterruptedIOException { Review Comment: @rschmitt But this exception does not represent a socket timeout. It is a different timeout by origin and as such it extends `InterruptedIOException` but not `SocketTimeoutException`. This enables the caller to differentiate socket timeouts that affect the entire connection and all its H2 streams from an individual H2 stream timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
