Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/31#discussion_r33881054
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
---
@@ -190,7 +192,8 @@ public void process(ClusterEvent event) throws
Exception {
private Message createMessage(HelixManager manager, String resourceName,
String partitionName,
String instanceName, String currentState, String nextState, String
sessionId,
- String stateModelDefName, String stateModelFactoryName, int
bucketSize) {
--- End diff --
This method has too many parameters, we need to just pass in resource or
have a message builder class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
