Github user kishoreg commented on a diff in the pull request:

    https://github.com/apache/helix/pull/31#discussion_r33881099
  
    --- Diff: helix-core/src/main/java/org/apache/helix/model/IdealState.java 
---
    @@ -55,7 +55,9 @@
         MAX_PARTITIONS_PER_INSTANCE,
         INSTANCE_GROUP_TAG,
         REBALANCER_CLASS_NAME,
    -    HELIX_ENABLED
    +    HELIX_ENABLED,
    +    RESOURCE_GROUP_NAME,
    +    RESOURCE_GROUP_ENABLED
    --- End diff --
    
    Why do we need ResourceGroupEnabled flag? Will things work as expected if 
there is a resourcegroupName and by default we can set the resourceGroupName to 
resourceName ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to