Github user kishoreg commented on a diff in the pull request:

    https://github.com/apache/helix/pull/31#discussion_r33882177
  
    --- Diff: helix-core/src/main/java/org/apache/helix/model/IdealState.java 
---
    @@ -536,4 +574,16 @@ public boolean isEnabled() {
       public void enable(boolean enabled) {
         _record.setSimpleField(IdealStateProperty.HELIX_ENABLED.name(), 
Boolean.toString(enabled));
       }
    +
    +  /**
    +   * Get the mangled IdealState name if resourceGroup is enable.
    +   *
    +   * @param resourceName
    +   * @param resourceTag
    +   *
    +   * @return
    +   */
    +  public static String getIdealStateName(String resourceName, String 
resourceTag) {
    --- End diff --
    
    why do we need this method? This convention can be completely handled on 
client side rt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to