Github user kongweihan commented on a diff in the pull request:

    https://github.com/apache/helix/pull/91#discussion_r115862430
  
    --- Diff: 
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
 ---
    @@ -210,6 +213,18 @@ private void 
updateStateTransitionMessageThreadPool(Message message, HelixManage
           return;
         }
     
    +    if (!_batchMessageThreadpoolChecked) {
    --- End diff --
    
    It seems to me as long as there's any `STATE_TRANSITION` message, this pool 
will be created, so why not simply instantiate this thread pool in the 
constructor?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to