Github user kongweihan commented on a diff in the pull request:
https://github.com/apache/helix/pull/91#discussion_r115871919
--- Diff:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
---
@@ -210,6 +213,18 @@ private void
updateStateTransitionMessageThreadPool(Message message, HelixManage
return;
}
+ if (!_batchMessageThreadpoolChecked) {
--- End diff --
Would it be better to pass it in? Each HelixManager for sure has a
DefaultMessagingService, which for sure has a HelixTaskExecutor. Using
NotificationContext to pass in the "parent object" just to do initialization
doesn't seem quite straightforward.
When I work on adding ThreadPoolExecutorMonitor for HelixTaskExecutor, I
actually have the same problem of getting InstanceType and ClusterName from
HelixManager. Maybe we should add it in the constructor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
