Github user kongweihan commented on a diff in the pull request:

    https://github.com/apache/helix/pull/91#discussion_r115901354
  
    --- Diff: 
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
 ---
    @@ -210,6 +213,18 @@ private void 
updateStateTransitionMessageThreadPool(Message message, HelixManage
           return;
         }
     
    +    if (!_batchMessageThreadpoolChecked) {
    --- End diff --
    
    I see, just to confirm, is backward compatibility the only concern here?
    I'm wondering if constructing HelixTaskExecutor with a HelixManager would 
make more sense, at all, if we're free to change the constructor?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to