----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29671/#review67566 -----------------------------------------------------------
ql/src/test/queries/clientpositive/selectDistinctStar.q <https://reviews.apache.org/r/29671/#comment111603> Add more test cases to cover more operators: ex: 1. select distinct * from src union all select distinct * from src1 2. select distinct * from src join src1 on src.key=src1.key 3. select * from (select distinct * from src)src1 join (select distinct * from src)src2 on src1.key=src2.key Also could you add tests to negative test driver - John Pullokkaran On Jan. 7, 2015, 9:16 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29671/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 9:16 p.m.) > > > Review request for hive and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > Support select distinct * in operator genaration phase. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 5d07fba > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 306edf6 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2d5c8c > ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7 > ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714 > ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION > ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION > ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/29671/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
