----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29671/ -----------------------------------------------------------
(Updated Jan. 10, 2015, 4:02 a.m.) Review request for hive and John Pullokkaran. Changes ------- Address John's comments. (1) add more test cases including both pos and neg tests. (2) remove spaces in code. Repository: hive-git Description ------- Support select distinct * in operator genaration phase. Diffs (updated) ----- itests/src/test/resources/testconfiguration.properties 68e9b7d ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 971910a ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7 ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714 ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out PRE-CREATION ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out PRE-CREATION ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION Diff: https://reviews.apache.org/r/29671/diff/ Testing ------- Thanks, pengcheng xiong
