----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29671/#review67784 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <https://reviews.apache.org/r/29671/#comment111855> The logic that builds AST is the same for CBO & non CBO path. why don't we pull it out put it in its own method. - John Pullokkaran On Jan. 13, 2015, 12:31 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29671/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 12:31 a.m.) > > > Review request for hive and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > Support select distinct * in operator genaration phase. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 917b3a4 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cea86df > ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7 > ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714 > ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION > ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION > ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION > ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out > PRE-CREATION > ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION > ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/29671/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
