> On Jan. 19, 2018, 11:41 a.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 122 (patched) > > <https://reviews.apache.org/r/65217/diff/1/?file=1942096#file1942096line122> > > > > nit: Why static?
I like my helper methods static :) > On Jan. 19, 2018, 11:41 a.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 150 (patched) > > <https://reviews.apache.org/r/65217/diff/1/?file=1942096#file1942096line150> > > > > nit: Can we stick to one notation? I do not like _ in function names :) fixed > On Jan. 19, 2018, 11:41 a.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 450 (patched) > > <https://reviews.apache.org/r/65217/diff/1/?file=1942096#file1942096line450> > > > > Question: Maybe in setup? Some tests depend on not having a table in HMS. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195795 ----------------------------------------------------------- On Jan. 19, 2018, 2:29 p.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65217/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2018, 2:29 p.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18468 > https://issues.apache.org/jira/browse/HIVE-18468 > > > Repository: hive-git > > > Description > ------- > > Adding IMetastoreClient API tests that cover alterPartition ande > renamePartition methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65217/diff/2/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
