----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195910 -----------------------------------------------------------
Thanks a lot Adam for the patch. It looks good to me, I just have few questions. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 223 (patched) <https://reviews.apache.org/r/65217/#comment275266> When altering a partition, is it possible to modify its StorageDescriptor and location? If so, what happens if we try to modify the sd or location to null or empty? Is it possible to change the columns in the partition's storage descriptor? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 497 (patched) <https://reviews.apache.org/r/65217/#comment275267> When tyring to alter two partitions, but an exception occurs during altering one of them, what happens with the other? All modification will be rolled back correctly? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 769 (patched) <https://reviews.apache.org/r/65217/#comment275268> What happens if the newPart partition has different db/table than the ones set in the method parameter? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 770 (patched) <https://reviews.apache.org/r/65217/#comment275269> What happens if the db/table is null in the newPart partition? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java Lines 771 (patched) <https://reviews.apache.org/r/65217/#comment275270> Is it possible to change any other attribute of a partition besides the value with the rename method? - Marta Kuczora On Jan. 19, 2018, 2:29 p.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65217/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2018, 2:29 p.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18468 > https://issues.apache.org/jira/browse/HIVE-18468 > > > Repository: hive-git > > > Description > ------- > > Adding IMetastoreClient API tests that cover alterPartition ande > renamePartition methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65217/diff/2/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
