> On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 223 (patched) > > <https://reviews.apache.org/r/65217/diff/2/?file=1942597#file1942597line223> > > > > When altering a partition, is it possible to modify its > > StorageDescriptor and location? > > If so, what happens if we try to modify the sd or location to null or > > empty? > > Is it possible to change the columns in the partition's storage > > descriptor?
SD can be changed completely, I change location by hand and I also added a change for col list now, thanks! > On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 497 (patched) > > <https://reviews.apache.org/r/65217/diff/2/?file=1942597#file1942597line497> > > > > When tyring to alter two partitions, but an exception occurs during > > altering one of them, what happens with the other? All modification will be > > rolled back correctly? Altered my test case to check this, it is rolled back correctly > On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 769 (patched) > > <https://reviews.apache.org/r/65217/diff/2/?file=1942597#file1942597line769> > > > > What happens if the newPart partition has different db/table than the > > ones set in the method parameter? Added test case for this > On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 770 (patched) > > <https://reviews.apache.org/r/65217/diff/2/?file=1942597#file1942597line770> > > > > What happens if the db/table is null in the newPart partition? Added test case for this > On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 771 (patched) > > <https://reviews.apache.org/r/65217/diff/2/?file=1942597#file1942597line771> > > > > Is it possible to change any other attribute of a partition besides the > > value with the rename method? Added test case for this - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195910 ----------------------------------------------------------- On Jan. 23, 2018, 1:38 p.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65217/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2018, 1:38 p.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18468 > https://issues.apache.org/jira/browse/HIVE-18468 > > > Repository: hive-git > > > Description > ------- > > Adding IMetastoreClient API tests that cover alterPartition ande > renamePartition methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65217/diff/3/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
