I would like to add another question to the list of Laszlo. 4) When a specific DI framework is chosen, what kinds of new dependencies will be introduced? (Are they conflicting with existing dependencies of Hive?)
Regards, --- Sungwoo Park On Thu, Apr 13, 2023 at 4:43 PM László Bodor <bodorlaszlo0...@gmail.com> wrote: > Thanks, guys for putting DI into scope, sounds very interesting, just a > couple of questions to help me understand and move this forward (and maybe > involve more folks with DI experience): > > 1) Can we have some examples, even with dummy code snippet-level, about > what we want to achieve? I mean, "utility classes with static methods are > baaaad" is not an example, even if I agree to a certain extent. > 2) Yes, DI helps with testing, but the question is, whether injecting will > happen only in tests or in production parts as well. > 3) What's the primary thing/object in your mind when it comes to injecting > something in the scope of Hive? > > TLDR: I remember an earlier experience with Spring when > it @InjectedWhateverIWantedWithAwesomeAnnotations, that's what I need to > see examples for in case of hive. > > Regards, > Laszlo Bodor > > > > Stamatis Zampetakis <zabe...@gmail.com> ezt írta (időpont: 2023. ápr. 13., > Cs, 9:33): > > > Just to be clear, I am in favor of introducing DI frameworks in Hive > > where it makes sense. As Attila said, we don't want to get stuck with > > legacy code forever. When a concrete proposal comes up we can discuss > > benefits vs drawbacks. > > > > Regarding stability I agree it is a pressing issue but Hive is an open > > source project and we certainly don't want to force volunteers to work > > on specific things or forbid them to work on others. Contributing to > > open source is supposed to be a fun and rewarding experience. I am > > sure many of the people in this list have stability as a primary goal > > so eventually we will get there. > > > > Best, > > Stamatis > > >