[
https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745674#comment-13745674
]
Jason Dere commented on HIVE-4844:
----------------------------------
Yeah, the diff does appear to be a bit off, doesn't look like it's very useful
does it? Might be better off just looking at the diff or applying it to
9fa33a6d0e7c18d6b94a29e8b6ef928126c9f274. I hope arcanist generated the diff
properly.
Removing the metastore changes does make some things a bit more consistent,
since there were times where we were just trying to use the base type name for
varchar, but in other instances where it was being used in a nested type we
would use the full name.
> Add char/varchar data types
> ---------------------------
>
> Key: HIVE-4844
> URL: https://issues.apache.org/jira/browse/HIVE-4844
> Project: Hive
> Issue Type: New Feature
> Components: Types
> Reporter: Jason Dere
> Assignee: Jason Dere
> Attachments: HIVE-4844.1.patch.hack, HIVE-4844.2.patch,
> HIVE-4844.3.patch, screenshot.png
>
>
> Add new char/varchar data types which have support for more SQL-compliant
> behavior, such as SQL string comparison semantics, max length, etc.
> NO PRECOMMIT TESTS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira