-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26968/#review58914
-----------------------------------------------------------


Hi,

I looked into this a little more, and I think that you should actually be able 
to use SearchArgument. The way you would do this is:

1) Create the SearchArgument object as here:

https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java#L293


2) Translate SearchArgument to FilterPredict.

Essentially instead of using the UDF classes and column list in 
FilterPredicateFactory you could use the SearchArgument object.

How does that sound?

- Brock Noland


On Oct. 21, 2014, 8:13 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26968/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 8:13 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8122: convert ExprNode to Parquet supported FilterPredict
> 
> 
> Diffs
> -----
> 
>   pom.xml 970da97ba2cae8a88e8641e76c88f1bd05c06f36 
>   
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/FilterPredicateFactory.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/LeafFilterBuilder.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/LeafFilterFactory.java 
> PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetRecordReaderWrapper.java
>  f5da46d392d8ac5f5589f66c37d567b1d3bd8843 
>   
> ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestFilterPredicateFactory.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26968/diff/
> 
> 
> Testing
> -------
> 
> local UT passed
> 
> 
> Thanks,
> 
> cheng xu
> 
>

Reply via email to