William A. Rowe, Jr. wrote:
> At 03:19 PM 4/4/2002, you wrote:
>
>> rederpj 02/04/04 13:19:32
>>
>> Modified: modules/filters mod_include.c
>> Log:
>> This patch fixes a core dump that occurs in mod_include during tag
>> parsing
>> if the starting sequence (<!--#) finishes at the end of a bucket
>> and the
>> directive starts at the beginning of the next bucket.
>
>
> Revision Changes Path
> 1.215 +47 -24 httpd-2.0/modules/filters/mod_include.c
>
> Could any of the three or so of you who have looked at this problem
> already
> vouch for Paul's solution here? One enthusiastic +1 from those who know
> this bug best would help sway me to get this fix straight into .34.
-1 for now, I'm afraid. With this new code, mod_include
is failing one of my test cases in which each character
of an otherwise-valid "<!--#include ... -->" directive
is contained in a separate bucket. This test case worked
with the original .34 mod_include code.
I'm debugging now.
--Brian
P.S.: My test case is:
* Create a file consisting of
<!--#include virtual="/whatever" -->
* Add Ctrl-B's between all the characters
* Run through the BUCKETEER filter before mod_include; this
will create bucket breaks where all the Ctrl-B's are.
