Sorry, finally catching up.  One suggestion...

At 03:07 PM 10/23/2003, [EMAIL PROTECTED] wrote:
>  --- mod_include.c     21 Sep 2003 21:29:27 -0000      1.232.2.3
>  +++ mod_include.c     23 Oct 2003 20:07:46 -0000      1.232.2.4
>  @@ -155,7 +155,7 @@
>           apr_table_setn(e, "DOCUMENT_PATH_INFO", r->path_info);
>       }
>       apr_table_setn(e, "USER_NAME", LAZY_VALUE);
>  -    if ((t = strrchr(r->filename, '/'))) {
>  +    if (r->filename && (t = strrchr(r->filename, '/'))) {
>           apr_table_setn(e, "DOCUMENT_NAME", ++t);
>       }

If the filename isn't absolute, don't we still want the document name, e.g.
something like this...

>  +    if (r->filename && ((t = strrchr(r->filename, '/')) || (t = r->filename))) {
>           apr_table_setn(e, "DOCUMENT_NAME", ++t);

which lets us have a unrooted filename passed as the environment variable?

Just a pendantic observation.

Bill 

Reply via email to