On Thu, 23 Oct 2003, [ISO-8859-15] André Malo wrote:
> * [EMAIL PROTECTED] wrote:
>
> > Log:
> > fix segfault which occured if the filename was not
> > set, for example, when processing some error conditions.
>
> > - if ((t = strrchr(r->filename, '/'))) {
> > + if (r->filename && (t = strrchr(r->filename, '/'))) {
> > apr_table_setn(e, "DOCUMENT_NAME", ++t);
> > }
>
> In fact, r->filename is used way more often within the includes filter
> (in error messages). Should we catch these cases as well, i.e. replace
> occurences of r->filename with r->filename ? r->filename : "<NULL>"?
Uck. I still think somebody ought to go on a mission to eliminate these
null r->filename cases. I don't have time tho. :( Maybe a good thing
for some of us to look at at the Con.
In the meanwhile I guess we should be checking for it to be null, though,
yes.
--Cliff
