--On Tuesday, February 25, 2003 1:47 PM -0500 Bill Stoddard <[EMAIL PROTECTED]> wrote:
I have to responds to this (even though I am up to my ears in other work)... If bb contains -any- bytes after after the call to ap_get_brigade(), then there is something wrong (that is fixable) in the filter stack. As I envision how this should operate, bb should be empty when we call apr_brigade_destroy. It it is not, then something else is broken.
Huh? How would a client read the body? ap_get_brigade has to return data. If you say that we now must always throw away the first read, you're scoring high on my hack-o-meter. =) We went this approach earlier with AP_MODE_INIT, but, ISTR, we ended up removing it. -- justin
Ok, I know what I was thinking. Check out tmp_bb in ap_read_request in protocol.c (unpatched version). We create tmp_bb, do read_request_line, ap_get_mime_headers then destroy tmp_bb. My patch does essentially the same thing. If there is a request body to read, whoeever needs to read it will create a new brigade. In this regard, my patch does not create any new bogosity. (and no, we do not throw away the first read).
Bill
