bnicholes 2004/03/31 14:56:08
Modified: modules/experimental util_ldap.c
Log:
Update the DN information associated with each LDAP connection after util_ldap_cache_checkuserid() rebinds the connection.
Revision Changes Path
1.22 +12 -0 httpd-2.0/modules/experimental/util_ldap.c
Index: util_ldap.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/experimental/util_ldap.c,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- util_ldap.c 9 Feb 2004 20:29:18 -0000 1.21
+++ util_ldap.c 31 Mar 2004 22:56:08 -0000 1.22
@@ -844,6 +844,18 @@
ldap_msgfree(res);
return result;
}
+ else {
+ /*
+ * Since we just bound the connection to the authenticating user id, update the
+ * ldc->binddn and ldc->bindpw to reflect the change and also to allow the next + * call to util_ldap_connection_open() to handle the connection reuse appropriately.
+ * Otherwise the next time that this connection is reused, it will indicate that
+ * it is bound to the original user id specified ldc->binddn when in fact it is + * bound to a completely different user id.
+ */
+ ldc->binddn = apr_pstrdup(st->pool, *binddn);
+ ldc->bindpw = apr_pstrdup(st->pool, bindpw);
isn't st->pool pconf? (or maybe I'm having trouble tracking ldc and st ;) )
can binddn and bindpw be repeatedly replaced with new values, creating uncontrolled growth of pconf?
