Rasmus Lerdorf wrote: > > On Fri, 20 Aug 2004, Jim Jagielski wrote: > > I'm reviewing this... I'm mostly investigating whether > > the check for keepalive!=1 before calling ap_set_keepalive > > in ap_send_http_header and ap_send_error_response is > > too ap_die() specific. It seems to me that > > ap_set_keepalive should be smarter internally about > > "double or more calls" per request. > > Yup, it should. I tried to minimize the amount of code I touched to fix > the problem at hand. > > The keepalive!=1 check prevents double-counting the request in the > keepalive counter. if keepalive!=1 we know that either ap_set_keepalive() > has not been called yet, or it has been called and keepalive is off, so in > either case we won't be double-counting the request. > > If ap_set_keepalive() was fixed to be immune to being called twice during > a request then those keepalive!=1 checks can be removed. >
I have some ideas :) -- =========================================================================== Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ "A society that will trade a little liberty for a little order will lose both and deserve neither" - T.Jefferson
