On Sun, Jan 11, 2009 at 05:36:07PM -0000, rj...@apache.org wrote: > Author: rjung > Date: Sun Jan 11 09:36:07 2009 > New Revision: 733493 > > URL: http://svn.apache.org/viewvc?rev=733493&view=rev > Log: > Allow to trigger rotatelogs log file rotation from > using HUP and INT signals to the rotatelogs process. > > This is helpful, when log activity is low, but you want > rotatelogs to close the open log files.
Sending SIGTERM to the rotatelogs process and having the parent recycle it should have done that already, surely, without adding all this complexity to rotatelogs? A lot of the stuff you're doing in the new signal handler is not async-signal safe, so -1. (closeFile notably calls pool functions) joe
