On 13.05.2009 22:38, William A. Rowe, Jr. wrote: > -1. There's really no excuse to abstract an abstraction, when you > could have simply added 'int special_stderr;' to the piped_log struct.
I reverted. Moving the new member to the existing piped_log structure makes it publicly visible. As for now we do not know any use case, where we actually want this to be set except for the main error log. > There are plenty of unnecessary changes here to accomplish what your > patch set out to do. Let's stick with KISS, this isn't Java code :) > > You are also patching many different things in this patch; error message > formatting, etc etc. Commit such as individual patches so that the > significant changes are not lost in the noise. OK > Please revert the introduction of a _wrapper struct and let's simply > fix the piped_log structure? Do we really want to add it to the public API?
