On Tue, Sep 22, 2009 at 12:04 PM, Ricardo Cantu <rica...@smartcsc.com>wrote:

> I think this patch will do it. See what you think.
>

Thanks!  I think just a couple of tweaks are needed.

Values of -1 for max_requests_per_process need to be fixed at config time so
that we don't clutter the main logic with migration support.  The function
that handles parsing that directive is set_max_requests_per_process() in
fcgid_conf.c.  Also in that file, DEFAULT_MAX_REQUESTS_PER_PROCESS needs to
be 0 instead of -1.  Then, the check

+        } else if (sconf->max_requests_per_process > 0    // negative and
zero are unlimited

doesn't have to be handled differently than the others.

(BTW, it is a tiny bit helpful to omit generated .html.* from patches.)

Reply via email to